[h1-2102] Partner's team member with no permission can retrieve services financial data
Medium
S
Shopify
Submitted None
Actions:
Reported by
imgnotfound
Vulnerability Details
Technical details and impact analysis
### Details
Unfortunately, I wasn't able to properly validate the following report as I could not get access the my partner's services option (event is ending in a few hours) and that access is manually given (https://help.shopify.com/en/partners/selling-services). However, given the observed behaviour, I assume there's a high probability of this being a missing permission check.
Within a partner's organization, financial datas are gated by the **View financials** permission. However, I observed that a staff with no permission is able to retrieve **Services** financial.
### Steps to reproduce
#### Partner's organization owner
1. Create a Partner's account on https://partners.shopify.com
1. Invite a team member with no permissions (go to **Teams > Invite staff member**, select no permission and complete the invite)
#### Partner's staff member with no permission
1. Accept the invite and log-in to the partner's dashboard
1. In the upper right corner, click on the notification bell image and intercept the GraphQL request being made to https://partners.shopify.com/:id/api/graphql
1. Update the payload to the following:
```
{
"query":"{ serviceMetrics { totalEarnings { amount } } }"
}
```
As a result, you will be returned the financial blocked:
```
{
"data":{
"serviceMetrics":{
"totalEarnings":{
"amount":"0.0"
}
}
}
}
```
Assuming that this property should be gated by the **View financials** permission, I should have received an access denied there instead of an amount (being `0.00` in my case as there's no data).
## Impact
Staff with no permissions, specifically the **View financials** is able to access **Services** financial data
Report Details
Additional information and metadata
State
Closed
Substate
Resolved
Submitted
Weakness
Improper Authorization