Loading HuntDB...

Generated passwords are not fully validated by HIBPValidator

Low
N
Nextcloud
Submitted None

Team Summary

Official summary from Nextcloud

Advisory at https://github.com/nextcloud/security-advisories/security/advisories/GHSA-c7mw-9q4r-8qwr

Reported by bjoernv

Vulnerability Details

Technical details and impact analysis

Weak Cryptography for Passwords
## Summary: If the Nextcloud server generates a secure random password (e.g. for sharing files), the validation is checked before the shuffle function str_shuffle() is called. In very rare cases it could happen, that a password is validated by HIBPValidator before str_shuffle(), but would not validate after shuffle. ## Steps To Reproduce: Since the password generation is usung random chars, the source code must be manipulated to see the problem. For instance take the password "Password123". Shuffle the Password to "o3rw1sasd2P". In Generator::generate() - delete: $password .= $chars = $this->random->generate($length, $chars); - insert: $password = "o3rw1sasd2P" Let the validator check the password - delete: $password = str_shuffle($password); - insert: $password = "Password123"; See the insecure password "Password123" in UI. ## Supporting Material/References: https://github.com/nextcloud/password_policy/blob/master/lib/Generator.php ## Impact In very rare cases the password generator may generate weak passwords.

Report Details

Additional information and metadata

State

Closed

Substate

Resolved

Bounty

$100.00

Submitted

Weakness

Weak Cryptography for Passwords