Missing GIT tag/commit verification in Docker
P
Paragon Initiative Enterprises
Submitted None
Actions:
Reported by
e3amn2l
Vulnerability Details
Technical details and impact analysis
in:
https://github.com/paragonie/airship/blob/master/docker/Dockerfile.airship#L14-L16
```
RUN git clone https://github.com/jedisct1/libsodium.git /tmp/sodium
WORKDIR /tmp/sodium
RUN git checkout tags/1.0.10
```
The code is fetched from Github without one of:
1\. signature verification on relevant tag. (GPG)
2\. specific commit. (SHA checksum)
more information about this issue:
https://www.qubes-os.org/doc/verifying-signatures/#verifying-qubes-code
fix: (implement 1 and/or 2)
1. verify GPG signature
use:
```
git tag -v <tag name>
```
to ensure the tag is signed.
Note: the tags in:
https://github.com/jedisct1/libsodium/tags
are signed, thus it's possible to implement this verification.
2. checkout known commit, such as:
```
git checkout fce6852d64339efa33c0ee4130b3107b888d6067
```
fce6852d64339efa33c0ee4130b3107b888d6067 is commit for tag 1.0.10 https://github.com/jedisct1/libsodium/commit/fce6852d64339efa33c0ee4130b3107b888d6067
Important note: The above operations need to be checked for errors (abort the script/don't proceed if error occurs)
Report Details
Additional information and metadata
State
Closed
Substate
Informative