Loading HuntDB...

Todos are not redacted when membership changes - Access to (confidential) issues and merge requests

Medium
G
GitLab
Submitted None
Reported by vaib25vicky

Vulnerability Details

Technical details and impact analysis

Information Disclosure
### Summary This vulnerability was fixed in https://gitlab.com/gitlab-org/gitlab-foss/-/issues/54349 , but it reappears maybe due to some new changes and one is able to reproduce the vulnerability to access confidential issues and MRs. All issues and MRs used to get redacted after one hour grace period but it is not happening anymore. The vulnerability only affects when user permissions changes from higher to lower. If user is removed from the project then the to-dos are getting redacted. ### Steps to reproduce * Owner of the project added a user with `Repository` access level. * User adds issues and MRs to his to-dos list * Owner changes user access level to `Guest` * Guest then use the api and get access to all new changes to the issues and MRs. `curl --header "PRIVATE-TOKEN: <User A Token>" https://mygitlab.example.com/api/v4/todos` ### Impact User still has access to (confidential) issues and merge requests after permission was removed. ### What is the current *bug* behavior? Bug still allows low access level user `Guest` to access confidential issues and MRs ### What is the expected *correct* behavior? Redact the confidential issues and MRs ###PoC In the image below, you can see MRs and issues are not redacted even after 2 hours. {F839117} ### Output of checks This bug happens on GitLab.com ## Impact Todos are not redacted when membership changes - Access to (confidential) issues and merge requests

Report Details

Additional information and metadata

State

Closed

Substate

Resolved

Submitted

Weakness

Information Disclosure